Skip to content
ZynnoraZynnora

Validate

Find it before your reviewer does

Check your development before review, with the reasoning behind every finding — so the same comment doesn't come back next time.

Check your developmentSee the lifecycle
A development passing a quality check, with findings and the reasoning for each.

Write. Check. Learn. Improve.

A bare list of warnings is a linter. The reasoning is what makes it a review — and what stops you writing the same thing twice.

Go deeper on any finding with ROB.

Database read inside a loop
LOOP AT lt_orders INTO ls_order.
  SELECT SINGLE name1 FROM kna1
    INTO lv_name WHERE kunnr = ls_order-kunnr.
ENDLOOP.

Why it matters

One database round trip per order, so cost grows with volume. Read the names once into a hashed table before the loop — the same fix applies wherever a loop needs data from another table.

What reviewers actually look for

Most review comments on ABAP come from these. Worth knowing either way.

  • Readability

    Names that describe intent.

  • Modularisation

    Units that do one thing.

  • Performance

    Selects in loops, over-selection.

  • Error handling

    Something the caller can act on.

  • Naming

    Consistent with project conventions.

  • Dead code

    Unreachable branches, unused variables.

  • Design fit

    Matches the approach that was agreed.

  • Maintainability

    Clear to whoever changes it next.

  1. Understand
  2. Design
  3. Build
  4. Validate
  5. Analyze

Questions about ABAP quality

No. ATC runs in your system with your check variant. Quality Check is an earlier self-review, and its value is the explanation attached to each finding.

Do the first review yourself.

Run the check on the development you were about to submit.

Check your developmentUnderstand code you didn't write

No SAP connection. No template rewrites.